hotfix: internal server rror feedback

This commit is contained in:
2026-04-18 12:41:44 +02:00
parent 61430317f4
commit a21f14ea87
2 changed files with 42 additions and 11 deletions

View File

@@ -78,7 +78,10 @@ async def create_branch(
stmt_refresh = ( stmt_refresh = (
select(CvVersion) select(CvVersion)
.where(CvVersion.id == new_version.id) .where(CvVersion.id == new_version.id)
.options(selectinload(CvVersion.patches)) .options(
selectinload(CvVersion.patches),
selectinload(CvVersion.public_assets),
)
) )
result = await session.execute(stmt_refresh) result = await session.execute(stmt_refresh)
return result.scalars().one() return result.scalars().one()
@@ -95,7 +98,10 @@ async def append_patches_to_version(
select(CvVersion) select(CvVersion)
.join(CvVersion.document) .join(CvVersion.document)
.where(CvVersion.id == version_id, CvDocument.owner_id == owner_id) .where(CvVersion.id == version_id, CvDocument.owner_id == owner_id)
.options(selectinload(CvVersion.patches)) .options(
selectinload(CvVersion.patches),
selectinload(CvVersion.public_assets),
)
) )
result = await session.execute(stmt) result = await session.execute(stmt)
version = result.scalars().one_or_none() version = result.scalars().one_or_none()
@@ -138,7 +144,10 @@ async def append_patches_to_version(
stmt_refresh = ( stmt_refresh = (
select(CvVersion) select(CvVersion)
.where(CvVersion.id == version_id) .where(CvVersion.id == version_id)
.options(selectinload(CvVersion.patches)) .options(
selectinload(CvVersion.patches),
selectinload(CvVersion.public_assets),
)
) )
result = await session.execute(stmt_refresh) result = await session.execute(stmt_refresh)
return result.scalars().one() return result.scalars().one()

View File

@@ -74,8 +74,14 @@ function UploadModal({ onClose, onDone }: { onClose: () => void; onDone: (doc: D
const submit = async () => { const submit = async () => {
if (!title.trim() || !file) { setError('Title and file required.'); return; } if (!title.trim() || !file) { setError('Title and file required.'); return; }
setLoading(true); setError(''); setLoading(true); setError('');
try { onDone(await uploadDocument(title.trim(), desc.trim() || null, file)); } try {
catch (e: unknown) { setError(e instanceof Error ? e.message : 'Upload failed'); setLoading(false); } const doc = await uploadDocument(title.trim(), desc.trim() || null, file);
await Promise.resolve(onDone(doc));
} catch (e: unknown) {
setError(e instanceof Error ? e.message : 'Upload failed');
} finally {
setLoading(false);
}
}; };
return ( return (
@@ -123,8 +129,14 @@ function BranchModal({
const submit = async () => { const submit = async () => {
if (!name.trim()) { setError('Branch name required.'); return; } if (!name.trim()) { setError('Branch name required.'); return; }
setLoading(true); setError(''); setLoading(true); setError('');
try { onDone(await createBranch(version.id, name.trim(), label.trim() || null, patches as Record<string, unknown>[])); } try {
catch (e: unknown) { setError(e instanceof Error ? e.message : 'Failed'); setLoading(false); } const v = await createBranch(version.id, name.trim(), label.trim() || null, patches as Record<string, unknown>[]);
await Promise.resolve(onDone(v));
} catch (e: unknown) {
setError(e instanceof Error ? e.message : 'Failed');
} finally {
setLoading(false);
}
}; };
return ( return (
@@ -170,8 +182,14 @@ function SubmissionModal({ version, onClose, onDone }: { version: Version; onClo
const submit = async () => { const submit = async () => {
if (!company.trim() || !role.trim()) { setError('Company and role required.'); return; } if (!company.trim() || !role.trim()) { setError('Company and role required.'); return; }
setLoading(true); setError(''); setLoading(true); setError('');
try { onDone(await createSubmission(version.id, company.trim(), role.trim(), url.trim() || null, jd.trim() || null)); } try {
catch (e: unknown) { setError(e instanceof Error ? e.message : 'Failed'); setLoading(false); } const s = await createSubmission(version.id, company.trim(), role.trim(), url.trim() || null, jd.trim() || null);
await Promise.resolve(onDone(s));
} catch (e: unknown) {
setError(e instanceof Error ? e.message : 'Failed');
} finally {
setLoading(false);
}
}; };
return ( return (
@@ -211,8 +229,12 @@ function PublishModal({ version, onClose, onDone }: { version: Version; onClose:
setLoading(true); setError(''); setLoading(true); setError('');
try { try {
const asset = await publishVersion(version.id, null, slug.trim() || null); const asset = await publishVersion(version.id, null, slug.trim() || null);
onDone(asset); await Promise.resolve(onDone(asset));
} catch (e: unknown) { setError(e instanceof Error ? e.message : 'Failed'); setLoading(false); } } catch (e: unknown) {
setError(e instanceof Error ? e.message : 'Failed');
} finally {
setLoading(false);
}
}; };
return ( return (